Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: /students marketing page #223

Merged
merged 3 commits into from
Mar 22, 2024
Merged

feat: /students marketing page #223

merged 3 commits into from
Mar 22, 2024

Conversation

zeucapua
Copy link
Contributor

Description

Implements /students page with data from Sanity CMS.

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Closes #222

Mobile & Desktop Screenshots/Recordings

Steps to QA

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented Mar 18, 2024

βœ… Deploy Preview for opensauced-landing ready!

Name Link
πŸ”¨ Latest commit f39f77d
πŸ” Latest deploy log https://app.netlify.com/sites/opensauced-landing/deploys/65f9bda4730ed100086bdac6
😎 Deploy Preview https://deploy-preview-223--opensauced-landing.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 91 (no change from production)
Best Practices: 92 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@zeucapua zeucapua marked this pull request as ready for review March 19, 2024 16:24
Copy link
Member

@jpmcb jpmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🎸

Comment on lines +28 to +31
{
link: "/contributors",
title: "Contributors",
description: "Start the path to your next contribution."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related: #227

@jpmcb jpmcb requested a review from a team March 19, 2024 16:48
Copy link
Member

@nickytonline nickytonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good, but for some reason the image coming from Sanity's CDN aren't loading. Not sure if this is just a deployment preview issue though. cc: @BekahHW

CleanShot 2024-03-19 at 12 56 40

@isabensusan
Copy link
Member

isabensusan commented Mar 19, 2024

⚠️ Let's not merge the PR just yet, I need to finish setting up the images

The changes look good, but for some reason the image coming from Sanity's CDN aren't loading. Not sure if this is just a deployment preview issue though. cc: @BekahHW

CleanShot 2024-03-19 at 12 56 40

It's loading fine! this is just a placeholder for the images :)

also, LGTM πŸ’―

@isabensusan isabensusan self-requested a review March 19, 2024 17:55
@isabensusan isabensusan merged commit cfe1887 into main Mar 22, 2024
6 checks passed
@isabensusan isabensusan deleted the feat/landing-for-students branch March 22, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Students landing page
4 participants