test(Hero): add e2e test for Hero component #434
Conversation
β Deploy Preview for hot-sauced-ui ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
NsdHSO
requested review from
0-vortex,
bdougie,
brandonroberts,
mtfoley,
shamimbinnur and
takanome-dev
|
I don't know why CI is failing, because on localhost work good |
There was a problem hiding this comment.
@NsdHSO you really need to adjust the URL to be a moving target. This PR is not going to get merged only checking absolute URLs. Resolving the conversation without making the change is not the way to go.
If you do not understand something please ask questions.
|
@0-vortex I think the scope of this issue, is only to check the accessibility, but no worries I can parse all your request. Please can you be more clear about what means absolute URLs? These? |
|
Hi please @0-vortex can you provide me more info about your comment? |
Co-authored-by: TED Vortex (Teodor-Eugen DuΘulescu) <[email protected]>
|
|
||
| await page2.getByText("7d") | ||
| .click(); | ||
| await page.locator("div:has-text(\"Find Open-Source Repositoriesto contribute today\")") |
There was a problem hiding this comment.
this looks like a typo but code is good now
What type of PR is this? (check all applicable)
Description
Related Tickets & Documents
Fixes #414
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?