fix: header and footer accessibility fixes: color contrast and image titles #427
+36
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for hot-sauced-ui ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Congrats on making your first Pull Request and thanks for taking the time to improve Open Sauced! ❤️! 🎉🍕
Say hello by joining the conversation in our Discord
JoshuaKGoldberg
commented
Dec 11, 2022
bdougie
approved these changes
Dec 12, 2022
|
🎉 This PR is included in version 2.29.0-beta.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
19 tasks
github-actions bot
pushed a commit
that referenced
this pull request
Dec 17, 2022
## [2.30.0-beta.1](v2.29.0...v2.30.0-beta.1) (2022-12-17) ### 🍕 Features * create admin status bar ([#401](#401)) ([91b1ee3](91b1ee3)), closes [#110](#110) ### 🐛 Bug Fixes * e2e testing not working in CI ([#421](#421)) ([8fd254f](8fd254f)) * header and footer accessibility fixes: color contrast and image titles ([#427](#427)) ([c154634](c154634)) * typo in handleVoteUpdateByRepo.ts ([#424](#424)) ([4033a80](4033a80)) * use aria-label instead of title for footer icons ([#428](#428)) ([7b150a6](7b150a6))
|
🎉 This PR is included in version 2.30.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Dec 17, 2022
## [2.30.0](v2.29.0...v2.30.0) (2022-12-17) ### 🍕 Features * create admin status bar ([#401](#401)) ([91b1ee3](91b1ee3)), closes [#110](#110) ### 🐛 Bug Fixes * e2e testing not working in CI ([#421](#421)) ([8fd254f](8fd254f)) * header and footer accessibility fixes: color contrast and image titles ([#427](#427)) ([c154634](c154634)) * typo in handleVoteUpdateByRepo.ts ([#424](#424)) ([4033a80](4033a80)) * use aria-label instead of title for footer icons ([#428](#428)) ([7b150a6](7b150a6))
|
🎉 This PR is included in version 2.30.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Related Tickets & Documents
Fixes #426
Mobile & Desktop Screenshots/Recordings
I wasn't sure what style change for the Sign In button would be best. Adding the text shadow meant I didn't need to add any new colors to the palette. In theory any change that increases color contrast just a bit could work, such as:
Added tests?
No(t yet). I'd love to add aXe in e2e tests but see the infra is actively being worked on in #403 -> #422
Added to documentation?
[optional] What gif best describes this PR or how it makes you feel?