Added paulrwade as a contributor & changed guestbook logo README file (resolves open-sauced/guestbook/issues/273) #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prw760
changed the title
prw760
changed the title
prw760
changed the title
prw760
changed the title
adiati98
requested changes
May 8, 2024
There was a problem hiding this comment.
Hi @paulrwade,
Thank you for your PR! ✨
However, we want to have separate PR for each issue.
That said, can you please:
- read the issue carefully and follow the requirements,
- address the review here,
- revert one commit (doesn't matter which one),
- create a new branch and a new PR for it,
- change the title to only reflect the changes you made in this PR,
- fill in the PR description in the PR template.
Please let me know if you've made the changes and if you have question or need help. 🙂
| @@ -1,6 +1,6 @@ | |||
| <div align="center"> | |||
| <br> | |||
| <img alt="Open Sauced" src="https://i.ibb.co/7jPXt0Z/logo1-92f1a87f.png" width="300px"> | |||
| <img alt="Open Sauced" src="https://github.com/open-sauced/assets/blob/main/logos/logo-on-dark.png" width="300"> | |||
There was a problem hiding this comment.
As per issue's request, we need to:
- remove the width here,
- Update the alt attribute to be "OpenSauced".
Suggested change
| <img alt="Open Sauced" src="https://github.com/open-sauced/assets/blob/main/logos/logo-on-dark.png" width="300"> | |
| <img alt="OpenSauced" src="https://github.com/open-sauced/assets/blob/main/logos/logo-on-dark.png"> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What type of PR is this? (check all applicable)
Related Issues
Contributors Checklist
I've read through the Getting Started section.
Have you run
npm run contributors:generateto generate your profile and the badge on the README?Added to documentation?
Screenshot (Required for PR Review)
[optional] What GIF best describes this PR or how it makes you feel?