Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add @Lor1138 as a contributor #276

Merged
merged 2 commits into from May 9, 2024
Merged

Conversation

Lor1138
Copy link
Contributor

@Lor1138 Lor1138 commented May 3, 2024

Description

This PR adds Lor1138 to the guestbook

What type of PR is this? (check all applicable)

  • 🀝 Add a contributor
  • πŸ“ Documentation Update

Related Issues

Contributors Checklist

I've read through the Getting Started section.

  • [ X] βœ… Yes
  • ❌ Not yet

Have you run npm run contributors:generate to generate your profile and the badge on the README?

  • [X ] βœ… Yes
  • ❌ No

Added to documentation?

  • πŸ“œ README.md
  • [X ] πŸ™… no documentation needed

Screenshot (Required for PR Review)

Screenshot 2024-05-02 at 9 14 21β€―PM

[optional] What GIF best describes this PR or how it makes you feel?

<iframe src="https://giphy.com/embed/hZj44bR9FVI3K" width="396" height="480" frameBorder="0" class="giphy-embed" allowFullScreen></iframe>

via GIPHY

@Lor1138 Lor1138 requested a review from a team as a code owner May 3, 2024 01:18
Copy link

github-actions bot commented May 3, 2024

Congratulations on completing Chapter 5 of the Intro to OSS Course with your contribution to this repository @Lor1138! You're almost to the end of the course. Create a highlight of your contribution to our guestbook using the instructions in chapter 6 and share it with us!

@Lor1138
Copy link
Contributor Author

Lor1138 commented May 3, 2024

Thank you for the opportunity to flex my open source muscles!

Copy link
Member

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Lor1138,
Thanks for the PR! ✨

This is not a blocker, but can you please fill in the description in the PR form?

For your future reference, completing the PR form is necessary for maintainers to understand the changes you made and it can streamline the review process.

Thank you! 😊

@Lor1138
Copy link
Contributor Author

Lor1138 commented May 3, 2024

What else should I put into the description? I followed the directions. hmmm

@CBID2
Copy link
Contributor

CBID2 commented May 4, 2024

What else should I put into the description? I followed the directions. hmmm

Put "This PR adds [insert your name here] to the guestbook" @Lor1138.

@adiati98
Copy link
Member

adiati98 commented May 4, 2024

What else should I put into the description? I followed the directions. hmmm

Hey @Lor1138,

Understanding and filling in PR templates is more tricky than issues because they only allows to be shown in the format of Markdown instead of form as in issues. πŸ˜…

Here are the tips that I hope can help you in the future!

When looking at a PR template:

  1. Look at the headings/subtitles. Usually, PR templates have headings (those with # symbol) of sections that you need to fill in.
  2. Read the comment outs carefully. Instructions in PR templates are commonly written in comment outs in every section. And this is what often get missed. In this beginner repo, we've provided an example of what to fill in the comment outs as you can see in below screenshot.

Screenshot 2024-05-04 084441

Another tips:

  • If there is no instructions to be found, pay attention to all headings and fill them in as much as you can. If you don't know what to fill, after you create your PR, ask the maintainers by leaving a comment.
  • Look at previous merged PRs and see how they structured to give you an idea on what to put in the sections.

I hope this helps! Feel free to reach out to me if you have any question or need help! πŸ˜„

@Lor1138
Copy link
Contributor Author

Lor1138 commented May 4, 2024

Thank you for the detailed instructions! I figured it out, I really appreciate the clarification.

Copy link
Member

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Lor1138,
We've helped you resolve the merge conflicts in your PR. ✨

Check out this section about how to resolve conflicts for your future reference.

If you haven't, you can join our community Discord. 😊
Also, check out our pizza-verse repo if you want to contribute further! πŸ•

pizza GIF

@adiati98 adiati98 merged commit 89e186e into open-sauced:main May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants