Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add @madefromjames as a contributor #270

Merged
merged 2 commits into from May 9, 2024

Conversation

madefromjames
Copy link
Contributor

@madefromjames madefromjames commented May 1, 2024

Description

This PR adds madefromjames as a contributor.

What type of PR is this? (check all applicable)

  • 🀝 Add a contributor
  • πŸ“ Documentation Update

Related Issues

Related issues: N/A

Contributors Checklist

I've read through the Getting Started section.

  • βœ… Yes
  • ❌ Not yet

Have you run npm run contributors:generate to generate your profile and the badge on the README?

  • βœ… Yes
  • ❌ No

Added to documentation?

  • πŸ“œ README.md
  • πŸ™… no documentation needed

Screenshot (Required for PR Review)

image

[optional] What GIF best describes this PR or how it makes you feel?

Beaming Face with Smiling Eyes

@madefromjames madefromjames requested a review from a team as a code owner May 1, 2024 07:45
Copy link

github-actions bot commented May 1, 2024

Congratulations on completing Chapter 5 of the Intro to OSS Course with your contribution to this repository @madefromjames! You're almost to the end of the course. Create a highlight of your contribution to our guestbook using the instructions in chapter 6 and share it with us!

@madefromjames madefromjames mentioned this pull request May 2, 2024
2 tasks
Copy link
Member

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @madefromjames,

Just a quick note here. You don't have an issue that accompanying this PR.
As for #123 that's just an example.

If you created an issue, the issue number is available right after your issue title as the example in the screenshot below:

Screenshot 2024-05-02 090457

That said, you can either:

  • put N/A in the "Related Issue" section, OR
  • create an issue and link it in your PR form.

Please let me know if you need any help. Thank you!

@madefromjames
Copy link
Contributor Author

madefromjames commented May 2, 2024

Hi @madefromjames,

Just a quick note here. You don't have an issue that accompanying this PR. As for #123 that's just an example.

If you created an issue, the issue number is available right after your issue title as the example in the screenshot below:

Screenshot 2024-05-02 090457

That said, you can either:

  • put N/A in the "Related Issue" section, OR
  • create an issue and link it in your PR form.

Please let me know if you need any help. Thank you!

There was no related issue to the PR and I've replaced it with N/A Please let me know if there's anything else that I need to do to make sure I'm on the right path. Thank you.

Copy link
Member

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @madefromjames,
We've helped you to resolve the merge conflicts in your PR! ✨

Check out [this section about how to resolve conflicts](https://github.com/open-sauced/guestbook#keeping-branch-up-to-date-and-resolving-merge-conflicts) for your future reference.

If you haven't, you can join our community Discord. 😊
Also, check out our pizza-verse repo if you want to contribute further! πŸ•

pizza GIF

@adiati98 adiati98 merged commit 3fa1a6c into open-sauced:main May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants