Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add @SimonGideon as a contributor #268

Merged
merged 1 commit into from May 8, 2024

Conversation

SimonGideon
Copy link
Contributor

@SimonGideon SimonGideon commented Apr 30, 2024

Description

In this PR I add myself as a contributor in the readMe markdown.

What type of PR is this? (check all applicable)

  • 🀝 Add a contributor
  • πŸ“ Documentation Update

Related Issues

Closes #267

Contributors Checklist

I've read through the Getting Started section.

  • βœ… Yes
  • ❌ Not yet

Have you run npm run contributors:generate to generate your profile and the badge on the README?

  • βœ… Yes
  • ❌ No

Added to documentation?

  • πŸ“œ README.md
  • πŸ™… no documentation needed

Screenshot (Required for PR Review)

Screenshot from 2024-04-30 19-35-48

[optional] What GIF best describes this PR or how it makes you feel?

image

@SimonGideon SimonGideon requested a review from a team as a code owner April 30, 2024 16:49
Copy link

Congratulations on completing Chapter 5 of the Intro to OSS Course with your contribution to this repository @SimonGideon! You're almost to the end of the course. Create a highlight of your contribution to our guestbook using the instructions in chapter 6 and share it with us!

Copy link
Member

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @SimonGideon,
Thank you for your PR! πŸ™Œ

However, please complete your PR form so we can understand and review the changes you made.

Can you please:

  • provide a description of the changes that you made.

Also, please add keyword Closes before your PR number, e.g: Closes #000. Adding this keyword will automatically close your issue as completed once it's merged.

We're only reviewing and accepting this PR once we get all the information needed.
Please let us know once you've completed the form.

Thank you! πŸ™‚

@SimonGideon SimonGideon changed the title feat: Add @SimonGideon as a contributor feat: Add @SimonGideon as a contributor Closes May 1, 2024
@SimonGideon SimonGideon requested a review from adiati98 May 1, 2024 10:11
@adiati98
Copy link
Member

adiati98 commented May 1, 2024

Hey @SimonGideon,

Sorry if my instruction wasn't clear.
What I mean was please add keyword Closes before your PR number in the Related Issues section β€” e.g: Closes #XXX β€” and not the title.

@SimonGideon SimonGideon changed the title feat: Add @SimonGideon as a contributor Closes feat: Add @SimonGideon as a contributor May 1, 2024
@SimonGideon
Copy link
Contributor Author

@adiati98 πŸ˜„ Thanks for making it clear. I have made the changes as requested.

@BekahHW BekahHW merged commit 6d08398 into open-sauced:main May 8, 2024
1 check passed
@ThembaMahlangu
Copy link

How does one contribute too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature:
4 participants