Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add RafaelJohn9 as a contributor #262

Merged
merged 7 commits into from May 14, 2024

Conversation

RafaelJohn9
Copy link
Contributor

@RafaelJohn9 RafaelJohn9 commented Apr 25, 2024

Description

I have added a new contributor (me) as per the open-sauced guide that closes the

What type of PR is this? (check all applicable)

  • 🀝 Add a contributor
  • πŸ“ Documentation Update

Related Issues

Closes #312

Contributors Checklist

I've read through the Getting Started section.

  • βœ… Yes
  • ❌ Not yet

Have you run npm run contributors:generate to generate your profile and the badge on the README?

  • βœ… Yes
  • ❌ No

Added to documentation?

  • πŸ“œ README.md
  • πŸ™… no documentation needed

Screenshot (Required for PR Review)

Screenshot from 2024-04-25 11-55-34

[optional] What GIF best describes this PR or how it makes you feel?

Gif

@RafaelJohn9 RafaelJohn9 requested a review from a team as a code owner April 25, 2024 09:05
Copy link

Congratulations on completing Chapter 5 of the Intro to OSS Course with your contribution to this repository @RafaelJohn9! You're almost to the end of the course. Create a highlight of your contribution to our guestbook using the instructions in chapter 6 and share it with us!

Copy link
Member

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @RafaelJohn9,
Thank you for your PR! πŸ™Œ

However, please complete your PR form so we can understand and review the changes you made.

Can you please:

  • make sure you fill all the areas in the form,
  • provide a description of the changes that you made in the "Description" section.

Also, you don't have issue assigned.

You can create an issue by following step 1 in the Getting Started section on the course and link the number of the issue in the "Related Issue" section.

We're only reviewing and accepting this PR once we get all the information needed.
Please let us know once you've completed the form.

Thank you. πŸ™‚

@RafaelJohn9
Copy link
Contributor Author

@adiati98 I have fixed the issue

@adiati98
Copy link
Member

Hey @RafaelJohn9 ,

We have merged a PR before yours. Please resolve the conflicts before we can review and merge yours.

Also, please be noticed that the number that you mentioned in the "Related Issue" section is your PR number and not your issue number. You don't have any issue that accompanying this PR. So you can leave an "N/A" here. :)

Do let us know if you need any help. Thanks. 😊

@RafaelJohn9
Copy link
Contributor Author

on it

@RafaelJohn9
Copy link
Contributor Author

@adiati98 its done

Copy link
Member

@BekahHW BekahHW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 39 in the readme should also be updating:

[![All Contributors](https://img.shields.io/badge/all_contributors-121-orange.svg?style=flat-square)](#contributors-)

Have you run npm run contributors:generate?

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

Copy link
Member

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @RafaelJohn9,
I've helped you run the generate command to increase the badge and generate your profile on README in your PR. ✨

Please pay attention to step 3 in this section about how to resolve conflicts. For your future contributions reference, you need to read instructions in any guidelines thoroughly.

I've also created an issue (#312) to accompany this PR. You can read this blog post about the importance of having an issue when contributing to open source projects.

If you haven't, you can join our community Discord. 😊
Also, check out our pizza-verse repo if you want to contribute further! πŸ•

pizza GIF

@adiati98 adiati98 requested a review from BekahHW May 14, 2024 06:59
@BekahHW BekahHW merged commit a2bea22 into open-sauced:main May 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add @RafaelJohn9 as a contributor
3 participants