Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: readme russian translation #255

Closed
wants to merge 5 commits into from

Conversation

krm-shrftdnv
Copy link

@krm-shrftdnv krm-shrftdnv commented Apr 10, 2024

Description

What type of PR is this? (check all applicable)

  • 🀝 Add a contributor
  • πŸ“ Documentation Update

Contributors checklist (check all applicable)

I've read through the Getting Started section.

  • βœ… Yes
  • ❌ Not yet

How did you add yourself as a contributor?

  • πŸ€– With CLI
  • ⌨️ Manually

If you added yourself manually, did you follow the emoji key and contribution types to fill in the value?

  • βœ… Yes
  • ❌ No

Have you run npm run contributors:generate to generate your profile and the badge on the README?

  • βœ… Yes
  • ❌ No

Added to documentation?

  • πŸ“œ README.md
  • πŸ™… no documentation needed

Screenshot (Required for PR Review)

image

[optional] What GIF best describes this PR or how it makes you feel?

@krm-shrftdnv krm-shrftdnv requested a review from a team as a code owner April 10, 2024 00:20
Copy link
Member

@BekahHW BekahHW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @krm-shrftdnv,

Please make sure you read the guidelines for community translations. Although we appreciate you translating, this doesn't follow the guidelines. Also, you should only address one issue per PR.

Please return back to the directions for the guestbook, and follow the directions for your PR title as well. Let me know if you have any questions.

@adiati98
Copy link
Member

Hey @krm-shrftdnv,

How's the progress here? Do you need any help?

As a reminder:

  • You have two changes here: Adding yourself as contributor and translation. But one PR may only address one issue.
  • If you'd like to translate the README, please read the "Community Translations" part in the How can I contribute? section carefully.

That said, please do the following:

  1. Revert this commit of translation. You can read this blogpost to do so.
  2. Change your PR title to add yourself to the guestbook. You can find the instruction about the PR title in the Getting Started section on our course.
  3. Fill in the "Description" section in your PR form. We cannot accept PR with incomplete PR form.
  4. Resolve the merge conflict. Refer to this guide to resolve the conflicts.

Thank you.

@BekahHW BekahHW closed this May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants