Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Ydigit as a contributor #254

Closed
wants to merge 4 commits into from

Conversation

Ydigit
Copy link

@Ydigit Ydigit commented Apr 9, 2024

Description

What type of PR is this? (check all applicable)

  • 🀝 Add a contributor
  • πŸ“ Documentation Update

Contributors checklist (check all applicable)

I've read through the Getting Started section.

  • βœ… Yes
  • ❌ Not yet

How did you add yourself as a contributor?

  • πŸ€– With CLI
  • ⌨️ Manually

If you added yourself manually, did you follow the emoji key and contribution types to fill in the value?

  • βœ… Yes
  • ❌ No

Have you run npm run contributors:generate to generate your profile and the badge on the README?

  • βœ… Yes
  • ❌ No

Added to documentation?

  • πŸ“œ README.md
  • πŸ™… no documentation needed

Screenshot (Required for PR Review)

screeenshoot

[optional] What GIF best describes this PR or how it makes you feel?

πŸ˜€

@Ydigit Ydigit requested a review from a team as a code owner April 9, 2024 19:55
Copy link

github-actions bot commented Apr 9, 2024

Congratulations on completing Chapter 5 of the Intro to OSS Course with your contribution to this repository @Ydigit! You're almost to the end of the course. Create a highlight of your contribution to our guestbook using the instructions in chapter 6 and share it with us!

Copy link
Member

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Ydigit ,
Thank you for your PR! ✨

We have merged a PR before yours. Please resolve the conflicts before we can review and merge yours.

Also, please fill in the "Description" section and complete the PR form.
Incomplete PR form will be marked invalid.

Do let us know if you need any help. Thanks. 😊

@Ydigit
Copy link
Author

Ydigit commented Apr 10, 2024

Hi adiati, is anything missing?, I fixed the conflicts, and the Description part.

@adiati98
Copy link
Member

Hey @Ydigit,

  1. I see the the "Description" section in your PR form is still empty. Please fill the description in.

  2. You haven't run the generate command after resolving conflicts. Please run this command first. You can refer to step 3 in the Resolving Merge Conflicts section.
    Note: You don't need to fix the README manually, as it will be generated automatically after you run this command.

  3. After you run it, please provide a new screenshot of your profile.

Please let me know if you have any question. Thank you.

@adiati98
Copy link
Member

@Ydigit I'd like to checking in.
How's the progress here? Do you need any help?

@adiati98
Copy link
Member

Hey @Ydigit,

We have merged a PR before yours. Please resolve the conflicts before we can review and merge yours.

Also, please fill in the "Description" section and complete the PR form.

You can do so by editing the PR form:

  1. Click the ... icon on top of the form.
  2. Select "Edit".

Warning

Incomplete PR form will be marked invalid and may be close.

Do let us know if you need any help. Thanks. 😊

@adiati98
Copy link
Member

adiati98 commented May 9, 2024

Hi @Ydigit,

As we don't get any response from you for a while, we're closing this PR.

Feel free to create a new PR to add yourself to the guestbook if you still want to work on it. πŸ™‚

Thank you.

@adiati98 adiati98 closed this May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants