Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: a11y rule "interactive-supports-focus" fails with a warning #4159

Open
wants to merge 4 commits into
base: beta
Choose a base branch
from
Open

fix: a11y rule "interactive-supports-focus" fails with a warning #4159

wants to merge 4 commits into from

Commits on Oct 11, 2024

  1. fix(.\components\tablist\tab-list.tsx): fixes a11y rule "interactive-… 

    …supports-focus" warning

The changes include adding tabIndex={0} to elements with role="tab" to ensure they are focusable for
keyboard navigation, addressing the accessibility warning (jsx-a11y/interactive-supports-focus).
Additionally, an onKeyDown handler was introduced to allow keyboard interaction, enabling users to
select tabs using the Enter or Space keys. These changes improve both accessibility and user
experience by making the tabs keyboard-accessible.

fixes open-sauced#4138
    @Bashamega
    Bashamega committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    30fbe56 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2024

  1. Update components/TabList/tab-list.tsx 

    Co-authored-by: Nick Taylor <[email protected]>
    @Bashamega @nickytonline
    Bashamega and nickytonline authored Oct 20, 2024
    Configuration menu
    Copy the full SHA
    4ed2d74 View commit details
    Browse the repository at this point in the history

  2. Update components/TabList/tab-list.tsx 

    Co-authored-by: Nick Taylor <[email protected]>
    @Bashamega @nickytonline
    Bashamega and nickytonline authored Oct 20, 2024
    Configuration menu
    Copy the full SHA
    c8d5121 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2024

  1. Merge branch 'beta' into fix/lint1

    @Bashamega
    Bashamega authored Oct 25, 2024
    Configuration menu
    Copy the full SHA
    201cd63 View commit details
    Browse the repository at this point in the history