Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: styling repo pages layout #3398

Merged
merged 7 commits into from
May 16, 2024
Merged

fix: styling repo pages layout #3398

merged 7 commits into from
May 16, 2024

Conversation

zeucapua
Copy link
Contributor

@zeucapua zeucapua commented May 16, 2024

Description

Fixes and styling changes throughout the repo pages. In collaboration with @isabensusan, the changes include:

  • Making the AvatarHoverCard images for the LotteryFactorChart smaller
  • Implements WorkspaceLayout to the 'contributors' tab for padding consistency and sidebar
  • Make ContributorsChart height fixed
  • New designs for chart tooltips
  • Text sizing changes throughout the cards
  • Padding changes throughout the cards
  • Color changes throughout the cards

Related Tickets & Documents

Closes #3397
Closes #3388
Closes #3387

Mobile & Desktop Screenshots/Recordings

LotteryFactorChart with smaller avatars
image

Contributors tab now has WorkspaceLayout
image

Issues & PR Charts (with Open and Closed/Merged colors)
Screenshot 2024-05-15 at 8 50 06 PM
Screenshot 2024-05-15 at 8 49 30 PM

Steps to QA

Tier (staff will fill in)

  • Tier 1
  • Tier 2
  • Tier 3
  • Tier 4

[optional] What gif best describes this PR or how it makes you feel?

steal-my-style-gucci-mane-gif

Copy link

netlify bot commented May 16, 2024

Deploy Preview for oss-insights ready!

Name Link
🔨 Latest commit a8854d5
🔍 Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/664665950eccce000845e7ee
😎 Deploy Preview https://deploy-preview-3398--oss-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 16, 2024

Deploy Preview for design-insights ready!

Name Link
🔨 Latest commit a8854d5
🔍 Latest deploy log https://app.netlify.com/sites/design-insights/deploys/66466595bd01f2000824af7b
😎 Deploy Preview https://deploy-preview-3398--design-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@zeucapua zeucapua marked this pull request as draft May 16, 2024 03:47
@zeucapua zeucapua marked this pull request as ready for review May 16, 2024 04:32
Copy link
Member

@bdougie bdougie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird height for the first card on mobile.

image

@zeucapua zeucapua requested review from bdougie and a team May 16, 2024 17:28
Copy link
Member

@bdougie bdougie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀🚀

Copy link
Contributor

@brandonroberts brandonroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗂️

Copy link
Member

@nickytonline nickytonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on a bunch of screens and looks great! 🚢

CleanShot.2024-05-16.at.15.57.04.mp4

@zeucapua zeucapua merged commit 376de84 into beta May 16, 2024
13 checks passed
@zeucapua zeucapua deleted the fix/repo-pages-layout branch May 16, 2024 20:03
open-sauced bot pushed a commit that referenced this pull request May 16, 2024
## [2.29.0-beta.6](v2.29.0-beta.5...v2.29.0-beta.6) (2024-05-16)

### 🐛 Bug Fixes

* styling repo pages layout ([#3398](#3398)) ([376de84](376de84))
open-sauced bot pushed a commit that referenced this pull request May 16, 2024
## [2.29.0](v2.28.0...v2.29.0) (2024-05-16)

### 🍕 Features

* capture all StarSearch prompts in PostHog ([#3405](#3405)) ([f7d8ac6](f7d8ac6))
* implemented Enriched UI responses for StarSearch ([#3394](#3394)) ([9886681](9886681))
* only tag maintainers for the specific repo on repo pages ([#3395](#3395)) ([54c9a93](54c9a93))

### 🐛 Bug Fixes

* Change closed issue state to purple on issues table ([#3406](#3406)) ([71b4478](71b4478))
* correct placeholder text in HighlightInput component ([#3348](#3348)) ([2ea0d24](2ea0d24))
* fixed TS error and logic for gathering prompt response ([#3410](#3410)) ([36d26c2](36d26c2))
* remove unused waitlist components ([#3404](#3404)) ([a99b113](a99b113))
* styling repo pages layout ([#3398](#3398)) ([376de84](376de84))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants