Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implemented Enriched UI responses for StarSearch #3394

Merged
merged 15 commits into from
May 16, 2024

Conversation

nickytonline
Copy link
Member

@nickytonline nickytonline commented May 15, 2024

Description

Implements an enriched UI for responses from StarSearch, e.g. adding a lottery factor chart when someone asks about lottery factor.

Currently the lottery factor widget is the only supported widget.

TODOS:

  • Now that things are working well for widgets loading in the UI, look at some refactoring (maybe)
  • Add Sentry logging where I put TODOs
  • Fix type for component loaded from dynamic import
  • Add some more comments in the code to explain the dynamic widget loading

Related Tickets & Documents

Closes #3372

Mobile & Desktop Screenshots/Recordings

CleanShot.2024-05-15.at.23.02.48.mp4

Steps to QA

  1. Go to StarSearch
  2. Ask a question along the lines of:
    • What is the lottery factor for React?
    • What is the lotto factor for React?
    • What is the bus factor for React?
  3. The first response is a lottery factor chart.
  4. The second response is a textual response in markdown converted to HTML.

Try existing canned prompts as well as your own to ensure things are still behaving properly.

Tier (staff will fill in)

  • Tier 1
  • Tier 2
  • Tier 3
  • Tier 4

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented May 15, 2024

Deploy Preview for design-insights ready!

Name Link
🔨 Latest commit 0d644e0
🔍 Latest deploy log https://app.netlify.com/sites/design-insights/deploys/664662d8e8ac4600093ed003
😎 Deploy Preview https://deploy-preview-3394--design-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 15, 2024

Deploy Preview for oss-insights ready!

Name Link
🔨 Latest commit 0d644e0
🔍 Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/664662d80d40d10008ae90c1
😎 Deploy Preview https://deploy-preview-3394--oss-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nickytonline nickytonline changed the title chore: wip feat: implemented Enriched UI responses for StarSearch May 15, 2024
@nickytonline nickytonline force-pushed the nickytonline/enriched-starsearch-ui branch 2 times, most recently from 70161aa to 10f6187 Compare May 16, 2024 03:00
@nickytonline nickytonline marked this pull request as ready for review May 16, 2024 15:02
@nickytonline nickytonline requested review from a team May 16, 2024 15:28
@nickytonline nickytonline force-pushed the nickytonline/enriched-starsearch-ui branch 2 times, most recently from 05ada26 to a169da5 Compare May 16, 2024 17:07
Copy link
Contributor

@brandonroberts brandonroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nickytonline nickytonline force-pushed the nickytonline/enriched-starsearch-ui branch from 1a41666 to 6a245d0 Compare May 16, 2024 19:42
Copy link
Contributor

@zeucapua zeucapua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

emril-lagasse-gif

@nickytonline nickytonline merged commit 9886681 into beta May 16, 2024
13 checks passed
@nickytonline nickytonline deleted the nickytonline/enriched-starsearch-ui branch May 16, 2024 19:51
open-sauced bot pushed a commit that referenced this pull request May 16, 2024
## [2.29.0-beta.5](v2.29.0-beta.4...v2.29.0-beta.5) (2024-05-16)

### 🍕 Features

* implemented Enriched UI responses for StarSearch ([#3394](#3394)) ([9886681](9886681))
open-sauced bot pushed a commit that referenced this pull request May 16, 2024
## [2.29.0](v2.28.0...v2.29.0) (2024-05-16)

### 🍕 Features

* capture all StarSearch prompts in PostHog ([#3405](#3405)) ([f7d8ac6](f7d8ac6))
* implemented Enriched UI responses for StarSearch ([#3394](#3394)) ([9886681](9886681))
* only tag maintainers for the specific repo on repo pages ([#3395](#3395)) ([54c9a93](54c9a93))

### 🐛 Bug Fixes

* Change closed issue state to purple on issues table ([#3406](#3406)) ([71b4478](71b4478))
* correct placeholder text in HighlightInput component ([#3348](#3348)) ([2ea0d24](2ea0d24))
* fixed TS error and logic for gathering prompt response ([#3410](#3410)) ([36d26c2](36d26c2))
* remove unused waitlist components ([#3404](#3404)) ([a99b113](a99b113))
* styling repo pages layout ([#3398](#3398)) ([376de84](376de84))
@bdougie bdougie added the tier 2 label May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Enriched Star Search Responses
4 participants