Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implemented StarSearch share prompt #3324

Open
wants to merge 8 commits into
base: beta
Choose a base branch
from

Conversation

nickytonline
Copy link
Member

@nickytonline nickytonline commented May 6, 2024

Description

not ecopy link and analytics are not implemented in the POC.

Related Tickets & Documents

Closes #3325

Mobile & Desktop Screenshots/Recordings

CleanShot 2024-05-06 at 21 13 21

Steps to QA

Tier (staff will fill in)

  • Tier 1
  • Tier 2
  • Tier 3
  • Tier 4

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented May 6, 2024

Deploy Preview for oss-insights ready!

Name Link
🔨 Latest commit a129c1a
🔍 Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/665a283984308800089458fd
😎 Deploy Preview https://deploy-preview-3324--oss-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 6, 2024

Deploy Preview for design-insights ready!

Name Link
🔨 Latest commit a129c1a
🔍 Latest deploy log https://app.netlify.com/sites/design-insights/deploys/665a2839e1046f0008359b76
😎 Deploy Preview https://deploy-preview-3324--design-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bdougie
Copy link
Member

bdougie commented May 6, 2024

I'd love to see us reuse elements from other places.

Gemini uses a share icon.

Screenshot 2024-05-06 at 4 50 30 PM

OpenSauced Highlights already have a share experience with the 3 dots.

Screenshot 2024-05-06 at 4 51 17 PM

I'd love to avoid adding more design debt with whatever solution we approach.

@bdougie
Copy link
Member

bdougie commented May 6, 2024

Thought this was the issue 😓 , but sharing my context.

@nickytonline
Copy link
Member Author

I've pushed changes to use the share dropdown @bdougie, but I think we could still run the risk of the prompt URL being too many characters for Twitter, but this should be an easy fix by either hashing it or using dub.co URLs.

@isabensusan
Copy link
Member

Loving the exploration!! The UI is looking a bit too busy, I'll do a quick design for just icons to simplify

image

@isabensusan
Copy link
Member

isabensusan commented May 28, 2024

@nickytonline

Icon

import { HiOutlineShare } from "react-icons/hi";
<HiOutlineShare />
image

@brandonroberts brandonroberts force-pushed the nickytonline/star-search-share branch from 743c707 to d4f5006 Compare May 30, 2024 15:02
@brandonroberts
Copy link
Contributor

brandonroberts commented May 30, 2024

This is ready for initial review @nickytonline @isabensusan

Screen.Recording.2024-05-30.at.10.49.31.AM.mov

Notes:

  • The Prompt URL will be shortened
  • If they aren't logged in, it doesn't auto-submit the prompt, but also doesn't force login
  • I can open a new PR if needed

@brandonroberts brandonroberts marked this pull request as ready for review May 30, 2024 15:51
Copy link
Member Author

@nickytonline nickytonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The share menu works but it seems put of place. Beside the two thumbs up with some gap would probably look better and only show it once the prompt response is completed.

CleanShot 2024-05-31 at 11 53 29

@brandonroberts
Copy link
Contributor

Updated the placement of the share icon and the logic to only take the first item in the chat session.

Screen.Recording.2024-05-31.at.2.41.49.PM.mov

Copy link
Member Author

@nickytonline nickytonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great @brandonroberts! One thing I wonder is for Twitter/X, we should truncate the prompt if it doesn't fit in a standard Tweet message length.

Also, a shorter URL would be great to increase the text count in a Tweet, but I imagine that unfurling potentially prevents an OG image from appearing?

@brandonroberts
Copy link
Contributor

Works great @brandonroberts! One thing I wonder is for Twitter/X, we should truncate the prompt if it doesn't fit in a standard Tweet message length.

Also, a shorter URL would be great to increase the text count in a Tweet, but I imagine that unfurling potentially prevents an OG image from appearing?

Yea, we could truncate the prompt, or not include it as it will be in the OG image. The short URL shouldn't prevent the OG image from appearing

@nickytonline
Copy link
Member Author

Works great @brandonroberts! One thing I wonder is for Twitter/X, we should truncate the prompt if it doesn't fit in a standard Tweet message length.
Also, a shorter URL would be great to increase the text count in a Tweet, but I imagine that unfurling potentially prevents an OG image from appearing?

Yea, we could truncate the prompt, or not include it as it will be in the OG image. The short URL shouldn't prevent the OG image from appearing

Good point that it's in the OG image so no need for it in the Tweet. Sounds good with that tweak and the short URL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Shareable StarSearch prompts
4 participants