fix: #3271 email validation #3273
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oss-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
✅ Deploy Preview for design-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Idrinth
changed the title
jpmcb
reviewed
Apr 30, 2024
lib/utils/validate-email.ts
Outdated
| ); | ||
| }; | ||
| const emailRegexp = | ||
| /^(([^<>()[\]\\.,;:\s@"]+(\.[^<>()[\]\\.,;:\s@"]+)*)|(".+"))@((\[[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\])|(([a-z\-0-9]+\.)+[a-z]{2,}))$/i; |
There was a problem hiding this comment.
Which regex is this? On the backend API, we use the HTML 5 email validator from the web standard spec:
It looks like this drifts abit. And I'd prefer if we aligned these.
There was a problem hiding this comment.
Hi, this is the same one as before, I just extracted it to prevent it from being rebuilt . Will update it to the one from the backend.
There was a problem hiding this comment.
Found the failure issue as well, the new regexp allows top level domains for emails, so adjusted the test to match that
Switch failure to success expectation due to changed regexp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the email validation
Related Tickets & Documents
Fixes #3271
Mobile & Desktop Screenshots/Recordings
N/A
Steps to QA
This cleans up some code and adds regression tests, so running
npm testis sufficient.Tier (staff will fill in)
[optional] Are there any post-deployment tasks we need to perform?
None I know of.
[optional] What gif best describes this PR or how it makes you feel?