fix: Now you can't type more than 255 characters in the bio field of user settings #2615
Conversation
…d after 255 characters (70) Now, it Can't keep typing in the bio field of user settings after 255 characters. Changed the code in user-sttings-page.tsx fix open-sauced#2612
👷 Deploy request for oss-insights pending review.Visit the deploys page to approve it
|
✅ Deploy Preview for design-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| {bio?.length}/255 | ||
| </p> | ||
| )} | ||
| <p aria-live="polite" className="text-xs"> |
There was a problem hiding this comment.
@BekahHW do you think being unable to type further and seeing 255/255 in the UI is clear enough? If not we can put a message along the lines of max length of bio reached when they hit 255 characters. The browser won't allow anymore characters because of the maxLength here which is what I proposed in the good first issue linked to this PR.
There was a problem hiding this comment.
@nickytonline how about we do the same as #2587 just to be consistent? 🙂
There was a problem hiding this comment.
Sorry, idk how I missed this.
We could put a message there, but I think the highlight one is too much here bc the input is so small.
This is what it currently looks like when it's too long:
What if we keep the 255/255 and have a message that says Bio Max Length underneath?
There was a problem hiding this comment.
Did we decide on something for this @BekahHW?
There was a problem hiding this comment.
@nickytonline I think my last suggestion is the way to go.
255/255 in red
Message: Bio Max Length in red
There was a problem hiding this comment.
Thanks for the PR @Pagla-Dasu! Just getting some feedback from my co-worker about the fix I proposed for this issue.
nickytonline
changed the title
|
@nickytonline you're welcome 👍🏼 |
|
@nickytonline , Any update on the PR? |
|
There are failures because of linting/prettier. run |
|
@nickytonline , The prettier issue is fixed, you can now merge the code. |
|
@Pagla-Dasu how are things going here? |
oh, I am so sorry @BekahHW, I missed your request for those changes. Will get that done asap. |
|
@nickytonline @BekahHW, do check the commit. The changes are made accordingly. |
Now, it Can't keep typing in the bio field of user settings after 255 characters. Changed the code in user-sttings-page.tsx
fix #2612
Description
This PR fixes the issue #2612 fixing the maximum character issue of 255 characters.
What type of PR is this? (check all applicable)
Related Tickets & Documents
Please use this format link issue numbers: Fixes #2612
#2612
Mobile & Desktop Screenshots/Recordings
Steps to QA
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?