Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add links to user profile on feeds userCard #1458

Merged
merged 6 commits into from Aug 2, 2023

Conversation

a0m0rajab
Copy link
Contributor

@a0m0rajab a0m0rajab commented Aug 1, 2023

Description

This PR adds redirect to profile page like the next:
In the feed page, the mention/tag to username redirects to OpenSauced profile

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Fixes #1447
Related to: #1449

Mobile & Desktop Screenshots/Recordings

This link in the feed page redirects to OpenSauced Profile:
image

To test

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@netlify
Copy link

netlify bot commented Aug 1, 2023

βœ… Deploy Preview for design-insights ready!

Name Link
πŸ”¨ Latest commit 888777e
πŸ” Latest deploy log https://app.netlify.com/sites/design-insights/deploys/64c9b5a314d6050008258f1c
😎 Deploy Preview https://deploy-preview-1458--design-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 1, 2023

βœ… Deploy Preview for oss-insights ready!

Built without sensitive environment variables

Name Link
πŸ”¨ Latest commit 888777e
πŸ” Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/64c9b5a37a00440008dd0463
😎 Deploy Preview https://deploy-preview-1458--oss-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@babblebey babblebey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG πŸ•

components/atoms/UserCard/user-card.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@OgDev-01 OgDev-01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go πŸ•

Copy link
Contributor

@NsdHSO NsdHSO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OgDev-01 OgDev-01 changed the title chore: add links to user profile chore: add links to user profile on feeds userCard Aug 2, 2023
@OgDev-01 OgDev-01 merged commit 6ce5957 into open-sauced:beta Aug 2, 2023
17 checks passed
@github-actions
Copy link

github-actions bot commented Aug 2, 2023

πŸŽ‰ This PR is included in version 1.58.0-beta.5 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

@github-actions
Copy link

github-actions bot commented Aug 2, 2023

πŸŽ‰ This PR is included in version 1.58.0 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: redirecting to user page from feed
5 participants