Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gave body uniform bg-color #1241

Closed
wants to merge 1 commit into from
Closed

Conversation

bpirrocco
Copy link
Contributor

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Description

This PR gives the body a background color equivalent to "bg-light-slate-2" to fix the appearance of the footer component in the extra-small to medium breakpoints. It also gets rid of that same appearance issue that appears at a smaller scale in the large and extra-large breakpoints.

Related Tickets & Documents

Fixes #1230

Mobile & Desktop Screenshots/Recordings

Medium Breakpoint Before:
image

Medium Breakpoint After:
image

Large Breakpoint Before:
image

Large Breakpoint After:
image

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

I am new to this, I did run 'npm test', and it passed all tests.

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

I don't believe so

[optional] What gif best describes this PR or how it makes you feel?

This is my first PR to an open source project, so I am very anxious but excited:)
image

@netlify
Copy link

netlify bot commented Jun 3, 2023

βœ… Deploy Preview for design-insights ready!

Name Link
πŸ”¨ Latest commit 50a68ac
πŸ” Latest deploy log https://app.netlify.com/sites/design-insights/deploys/647a92a46cd40c00081cf658
😎 Deploy Preview https://deploy-preview-1241--design-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jun 3, 2023

βœ… Deploy Preview for oss-insights ready!

Built without sensitive environment variables

Name Link
πŸ”¨ Latest commit 50a68ac
πŸ” Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/647a92a47e836e0008ddb78b
😎 Deploy Preview https://deploy-preview-1241--oss-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Protected Branch

In order to be considered for merging, the pull request changes must not be implemented on the "beta" branch. This is described in our Contributing Guide. We would suggest that you close this PR and implement your changes as described in our Contributing Guide and open a new pull request.

Conventional Commit PR Title

In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:

  • docs: correct typo in README
  • feat: implement dark mode"
  • fix: correct remove button behavior

Linting Errors

  • Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
  • No subject found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Footer location on small screens
1 participant