Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: undefined config during build #158

Merged
merged 3 commits into from Jun 3, 2023
Merged

fix: undefined config during build #158

merged 3 commits into from Jun 3, 2023

Conversation

Anush008
Copy link
Member

@Anush008 Anush008 commented Jun 3, 2023

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Description

This PR updates the help page to import the version from package.json instead of vite-env.d.ts. It also removes an unused variable from vite-env.d.ts and removes definition from vite.config.ts.

Generated using OpenSauced.

Related Tickets & Documents

Resolves #156.

Mobile & Desktop Screenshots/Recordings

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

@Anush008 Anush008 requested a review from diivi June 3, 2023 01:51
@Anush008 Anush008 requested a review from bdougie June 3, 2023 01:56
@Anush008 Anush008 mentioned this pull request Jun 3, 2023
2 tasks
Copy link
Member

@bdougie bdougie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging to unblock but now seeing this error #157

@bdougie bdougie merged commit c986086 into beta Jun 3, 2023
6 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 3, 2023
## [1.3.1-beta.5](v1.3.1-beta.4...v1.3.1-beta.5) (2023-06-03)

### πŸ› Bug Fixes

* undefined config during build ([#158](#158)) ([c986086](c986086))
@github-actions
Copy link

github-actions bot commented Jun 3, 2023

πŸŽ‰ This PR is included in version 1.3.1-beta.5 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

github-actions bot pushed a commit that referenced this pull request Jun 3, 2023
## [1.4.0](v1.3.0...v1.4.0) (2023-06-03)

### βœ… Tests

* add tests for checkAuth.ts ([#149](#149)) ([3a79fac](3a79fac))
* add tests for utils/urlMatchers.ts ([#143](#143)) ([26702e6](26702e6))

### πŸ› Bug Fixes

* Post a highlight ([#101](#101)) ([e3b7051](e3b7051))
* remove auto-take message from triage.yml ([258a828](258a828))
* rename triage.yml ([3b9a14b](3b9a14b))
* undefined config during build ([#158](#158)) ([c986086](c986086))

### πŸ• Features

* latest highlights ([#154](#154)) ([0ccd0e7](0ccd0e7))
* uses username on highlight instead of full name ([#162](#162)) ([801fe5a](801fe5a))
@github-actions
Copy link

github-actions bot commented Jun 3, 2023

πŸŽ‰ This PR is included in version 1.4.0 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

@Anush008 Anush008 deleted the login-fix branch June 3, 2023 11:01
zer0and1 added a commit to zer0and1/open-sauced.ai that referenced this pull request Jul 26, 2023
## [1.3.1-beta.5](open-sauced/ai@v1.3.1-beta.4...v1.3.1-beta.5) (2023-06-03)

### πŸ› Bug Fixes

* undefined config during build ([#158](open-sauced/ai#158)) ([c986086](open-sauced/ai@c986086))
zer0and1 pushed a commit to zer0and1/open-sauced.ai that referenced this pull request Jul 26, 2023
## [1.4.0](open-sauced/ai@v1.3.0...v1.4.0) (2023-06-03)

### βœ… Tests

* add tests for checkAuth.ts ([#149](open-sauced/ai#149)) ([3a79fac](open-sauced/ai@3a79fac))
* add tests for utils/urlMatchers.ts ([#143](open-sauced/ai#143)) ([26702e6](open-sauced/ai@26702e6))

### πŸ› Bug Fixes

* Post a highlight ([#101](open-sauced/ai#101)) ([e3b7051](open-sauced/ai@e3b7051))
* remove auto-take message from triage.yml ([258a828](open-sauced/ai@258a828))
* rename triage.yml ([3b9a14b](open-sauced/ai@3b9a14b))
* undefined config during build ([#158](open-sauced/ai#158)) ([c986086](open-sauced/ai@c986086))

### πŸ• Features

* latest highlights ([#154](open-sauced/ai#154)) ([0ccd0e7](open-sauced/ai@0ccd0e7))
* uses username on highlight instead of full name ([#162](open-sauced/ai#162)) ([801fe5a](open-sauced/ai@801fe5a))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Cannot test beta build due to config error
2 participants