Skip to content

Drop compat.h #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 31, 2025
Merged

Drop compat.h #10

merged 2 commits into from
Mar 31, 2025

Conversation

lilith218
Copy link
Member

@lilith218 lilith218 commented Mar 28, 2025

Remove

  • compat.h file and drop related tests

@db7
Copy link
Member

db7 commented Mar 28, 2025

I don't think we need to add compat.h opensource vatomic. The interface mapped by compat.h is v1.0. That was never public. What do you think?

@lilith218
Copy link
Member Author

I don't think we need to add compat.h opensource vatomic. The interface mapped by compat.h is v1.0. That was never public. What do you think?

compat.h exists already without its template. Either we drop it, or we add the template.

@db7
Copy link
Member

db7 commented Mar 31, 2025

True. I'd suggest dropping it.

@lilith218 lilith218 force-pushed the lilith/add-missing-tmp branch from 7618246 to d74d6da Compare March 31, 2025 09:50
@lilith218 lilith218 changed the title Add missing compat.h template Drop compat.h Mar 31, 2025
@lilith218 lilith218 changed the title Drop compat.h Draft: Drop compat.h Mar 31, 2025
Signed-off-by: Lilith Oberhauser <[email protected]>
@lilith218 lilith218 requested a review from db7 March 31, 2025 10:01
@lilith218 lilith218 changed the title Draft: Drop compat.h Drop compat.h Mar 31, 2025
Signed-off-by: Lilith Oberhauser <[email protected]>
@lilith218 lilith218 merged commit ea3e244 into main Mar 31, 2025
57 checks passed
@lilith218 lilith218 deleted the lilith/add-missing-tmp branch March 31, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants