Skip to content

fix:fixed outdated prefetch #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

fix:fixed outdated prefetch #209

wants to merge 12 commits into from

Conversation

lrlrl
Copy link

@lrlrl lrlrl commented Mar 12, 2025

The arm64.h implementation in the libvysnc project has been modified, and the prefetch patch in the examples\tilt\locks directory is outdated.

lrlrl
lrlrl commented Mar 12, 2025
View reviewed changes
Copy link
Author

@lrlrl lrlrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Referring to the leveldb implementation in the tutorials\leveldb-bench directory, the benchmark implementation of kyotocabinet using locks is completed(all implementations use locks).

@db7
Copy link
Member

db7 commented Mar 12, 2025

Why is that patch of the atomics necessary, that sounds fishy.

@apaolillo
Copy link
Collaborator

it was a patch that was responsible for a performance regression back then. I'm not sure it is still a working use case nowadays.

@db7
Copy link
Member

db7 commented Mar 12, 2025

I see. Yeah, that file has changed meanwhile

@apaolillo
Copy link
Collaborator

@lrlrl why the moving of kyoto cabinet? Lots of downstream relies on kyoto cabinet being in example/ so I wouldn't move it. Especially since this is not related to this change.

@apaolillo apaolillo marked this pull request as draft March 19, 2025 19:28
@lrlrl lrlrl marked this pull request as ready for review March 27, 2025 01:32
@lrlrl
Copy link
Author

lrlrl commented Mar 27, 2025

@apaolillo Sorry to reply to your message now. Got it, I'll move kyotocabinet back under example/ and modify it according to the format of leveldb.

apaolillo and others added 9 commits March 27, 2025 18:12
@apaolillo @lrlrl
Fix charting types as they are not required (open-s4c#215)
11c3490 
Signed-off-by: Antonio Paolillo <[email protected]>
@theodegeest @lrlrl
examples/tilt: requirements & typo (open-s4c#214)
5499f26
@db7 @lrlrl
Minimal support for Darwin (open-s4c#212)
6dfdceb 
To run benchkit on macOS a mock function to return a constant boot
string has to be implemented.

Signed-off-by: Diogo Behrens <[email protected]>
@apaolillo @lrlrl
Fix formatting (open-s4c#216)
16f52c2 
Signed-off-by: Antonio Paolillo <[email protected]>
@lrlrl
update kyotocabinet
529a574 
Signed-off-by: “lrlrl” <[email protected]>
@lrlrl
modify configuration
2dfa1d2 
Signed-off-by: “lrlrl” <[email protected]>
@lrlrl
fix format
5031068 
Signed-off-by: “lrlrl” <[email protected]>
@lrlrl
fix format
09d6eb2 
Signed-off-by: “lrlrl” <[email protected]>
@lrlrl
fixed format
66128f8 
Signed-off-by: “lrlrl” <[email protected]>
@lrlrl
Copy link
Author

lrlrl commented Mar 27, 2025

I'm very sorry that the Signed-off-by was added by mistake because I am not familiar with GitHub, but it has been successfully modified.

@lrlrl
Copy link
Author

lrlrl commented Mar 27, 2025

Sorry again for adding a lot of unnecessary commit records due to my mistake. You can turn off that PR if you want and I'll resubmit it again.

@lrlrl lrlrl closed this Mar 27, 2025
@lrlrl lrlrl reopened this Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lrlrl @db7 @apaolillo @theodegeest