Dont redirect to another allreduce algorithm. #12552
Merged
+8
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenduwan
approved these changes
May 16, 2024
|
@bosilca Could you please resolve the conflict? |
The decision to switch to a different algorithm based on count does not belong to the base algorithms, it should be done in the upper level decision functions. Signed-off-by: George Bosilca <[email protected]>
bosilca
force-pushed
the
fix/no_linear_allreduce_in_base_allreduce_scatter_allgather
branch
from
ee35f84
to
7a1a4e6
Compare
bosilca
deleted the
fix/no_linear_allreduce_in_base_allreduce_scatter_allgather
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The decision to switch to a different algorithm based on count does not belong to the base algorithms, it should be done in the upper level decision functions.
We need to validate the performance for small allreduce at mid-range scale to make sure this does not negatively affect the allreduce.
Fixes #12550.