changing variable name for inference start time for proper latency calculation when using --infer_time #1471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sec_per_example is calculated from different start time than the experiment start and logs wrong value. Really short sec_per_example was also raised in these issues #1464 and #1468.
steps required to reproduce the bug
python3 test.py --cfg_file cfgs/nuscenes_models/cbgs_dyn_pp_centerpoint.yaml --ckpt ../checkpoints/cbgs_pp_centerpoint_nds6070.pth --infer_timeis showing
2023-10-03 10:40:45,533 INFO *************** EPOCH 6070 EVALUATION ***************** eval: 100%|█████████████████████████████████████████████████████████████████████████████████████████| 162/162 [00:17<00:00, 9.33it/s, infer_time=58.17(101.47), recall_0.3=(0, 4375) / 5519] 2023-10-03 10:41:02,902 INFO *************** Performance of EPOCH 6070 ***************** 2023-10-03 10:41:02,902 INFO Generate label finished(sec_per_example: 0.0005 second).This fix solves and shows the correct sec_per_example value.
2023-10-03 10:42:12,475 INFO *************** EPOCH 6070 EVALUATION ***************** eval: 100%|█████████████████████████████████████████████████████████████████████████████████████████| 162/162 [00:17<00:00, 9.22it/s, infer_time=53.93(101.71), recall_0.3=(0, 4375) / 5519] 2023-10-03 10:42:30,057 INFO *************** Performance of EPOCH 6070 ***************** 2023-10-03 10:42:30,057 INFO Generate label finished(sec_per_example: 0.1085 second).