Correct once dataset default path and paths for data generation #1207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…) without Loader=... is deprecated in latest virsion)
…nore list to generate dataset properly(if download dataset without raw datas, dataset generator not working)
jihanyang
reviewed
Dec 2, 2022
| @@ -4,7 +4,7 @@ numba | |||
| torch>=1.1 | |||
| tensorboardX | |||
| easydict | |||
| pyyaml | |||
| pyyaml==5.4.1 | |||
There was a problem hiding this comment.
May I know why need to fix the pyyaml version?
There was a problem hiding this comment.
Based on source, it use yaml.load() function for loading yaml scripts, but it is deprecated in latest version and causing error : "load() missing 1 required positional argument 'loader'".
So, it might need to fix the pyyaml version supporting yaml.load() function.
(Another option i found is replacing it to yaml.full_load() in latest version of pyyaml)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous code attempted to generate for all type of data inside splits list(which has ["train", "val", "test", "raw_small", "raw_medium", "raw_large"]).
It occurs error even if just one split doesn't exist in data path.
Therefore, I correct it to generate only existing data splits.