Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): highlight search text functionality for description column #19248

Merged

Conversation

pranita09
Copy link
Contributor

@pranita09 pranita09 commented Jan 6, 2025

Describe your changes:

Fix #19077

Worked on highlight search text functionality for description column, as it was not working after implementation of RichTextEditorPreviewerV1 component.

Before:

Screen.Recording.2025-01-06.at.4.39.31.PM.mov

After:

Screen.Recording.2025-01-06.at.4.40.20.PM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Copy link
Contributor

github-actions bot commented Jan 6, 2025

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@pranita09 pranita09 marked this pull request as ready for review January 6, 2025 11:16
@pranita09 pranita09 requested a review from a team as a code owner January 6, 2025 11:16
@ShaileshParmar11 ShaileshParmar11 added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs labels Jan 6, 2025
Copy link
Contributor

github-actions bot commented Jan 6, 2025

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
64.51% (40598/62935) 40.76% (16266/39905) 43.84% (4916/11213)

Copy link

sonarqubecloud bot commented Jan 7, 2025

@chirag-madlani chirag-madlani merged commit 498d952 into open-metadata:main Jan 7, 2025
28 of 30 checks passed
Copy link
Contributor

github-actions bot commented Jan 7, 2025

Changes have been cherry-picked to the 1.6.2 branch.

github-actions bot pushed a commit that referenced this pull request Jan 7, 2025
Co-authored-by: Chirag Madlani <[email protected]>
(cherry picked from commit 498d952)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search Term Highlight Feature
4 participants