FIX #19232 - Correct array type mapping in ORM converter #19241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Ingestion
safe to test
pmbrull
commented
Jan 6, 2025
| @@ -76,7 +76,9 @@ def map_types(self, col: Column, table_service_type): | |||
| """returns an ORM type""" | |||
|
|
|||
| if col.arrayDataType: | |||
| return self._TYPE_MAP.get(col.dataType)(item_type=col.arrayDataType) | |||
| return self._TYPE_MAP.get(col.dataType)( | |||
| item_type=self._TYPE_MAP.get(col.arrayDataType) | |||
There was a problem hiding this comment.
we were passing OM's DataType instead of a real ORM
pmbrull
commented
Jan 6, 2025
| @@ -94,6 +94,12 @@ def _process_col_type(self, column: dict, schema: str) -> Tuple: | |||
| parsed_string["name"] = column["name"] | |||
| else: | |||
| col_type = ColumnTypeParser.get_column_type(column["type"]) | |||
| # For arrays, we'll get the item type if possible, or parse the string representation of the column | |||
| # if SQLAlchemy does not provide any further information | |||
| if col_type == "ARRAY" and getattr(column["type"], "item_type"): | |||
There was a problem hiding this comment.
we were ignoring the item_type property if it ever was informed and only relied on the str representation of the types
ulixius9
approved these changes
Jan 6, 2025
9 tasks
ayush-shah
pushed a commit
that referenced
this pull request
Jan 7, 2025
tutte
added
To release
pmbrull
added a commit
that referenced
this pull request
Jan 7, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Fixes #19232
Sampler was failing for postgres array types. There were 2 issues:
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>