Skip to content

Conversation

da5nsy
Copy link
Contributor

@da5nsy da5nsy commented Aug 29, 2025

FOR CONTRIBUTOR

PR Type:

  • This PR adds a new blog post
  • This PR does something else (explain above)

FOR REVIEWERS

Thanks for taking the time to review! ❤️

Here are the list of things to make sure of:

  • The website builds (a check will fail if not)
  • All images have been added within the Pull Request and they have Alt text
  • If there are paragraphs or text, the key messages are highlighted
  • All internal links (within OLS website) use the {% link path_to_file.md %} format
  • The preview corresponds to the changes described in the Pull Request
  • The code is tidy and passes the linting tests

Copy link
Collaborator

@NPDebs NPDebs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thank you, @da5nsy! 🌟

@da5nsy
Copy link
Contributor Author

da5nsy commented Aug 29, 2025

Do you know why the deploy preview is failing @NPDebs?
(I'm curious because we're exploring different deploy preview options in The Turing Way and I don't think I've seen a functional github pages one, which supports previews from forks, yet)

@NPDebs
Copy link
Collaborator

NPDebs commented Aug 29, 2025

Do you know why the deploy preview is failing @NPDebs? (I'm curious because we're exploring different deploy preview options in The Turing Way and I don't think I've seen a functional github pages one, which supports previews from forks, yet)

Yes, please! The deploy preview fails here because of a scope/permissions issue.

Right now, the workflow uses a repo-scoped GITHUB_TOKEN (line 36) that isn’t available to workflows triggered from forks. That’s why previews work if the branch is created directly on this repo, but fail for branches from forks.

It’s a GitHub Actions limitation. Secrets (including the built-in token) aren’t passed to workflows from forked PRs for security reasons.

I guess this is why many resort to external services like Netlify or Vercel...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants