Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce Resolver as a drop in replacement for Evaluator #793

Merged

Conversation

Kavindu-Dodan
Copy link
Collaborator

@Kavindu-Dodan Kavindu-Dodan commented May 17, 2024

This PR

To have consistent naming, I have introduced Config.Resolver as a drop-in replacement of Config.Evaluator. No breaking change as internal handling is done through a common interface.

Old

FlagdProvider flagdProvider = new FlagdProvider(
        FlagdOptions.builder()
                .resolverType(Config.Evaluator.IN_PROCESS)
                .build());

New

FlagdProvider flagdProvider = new FlagdProvider(
        FlagdOptions.builder()
                .resolverType(Config.Resolver.IN_PROCESS)
                .build());

Config.Evaluator is deprecated and will be removed in a future release.

@Kavindu-Dodan Kavindu-Dodan force-pushed the feat/evaluator-to-resolver-rename branch from 2ed1770 to e53a03a Compare May 24, 2024 16:08
@Kavindu-Dodan Kavindu-Dodan marked this pull request as ready for review May 24, 2024 16:08
@Kavindu-Dodan Kavindu-Dodan requested a review from a team as a code owner May 24, 2024 16:08
Copy link
Member

@toddbaert toddbaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@toddbaert toddbaert merged commit 618a64a into open-feature:main May 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants