Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] Bitfield record class #59

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

[feature] Bitfield record class #59

wants to merge 13 commits into from

Commits on May 18, 2024

  1. [feat] add read_bytes() and write_bytes() methods 

    This is required for bitfields to be able to read or write an arbitrary number of bytes from/to the stream.
    @ngjunsiang
    ngjunsiang committed May 18, 2024
    Configuration menu
    Copy the full SHA
    f0f86f0 View commit details
    Browse the repository at this point in the history

  2. [refactor] add specific non-octet-size type aliases for bitfields 

    This might change in future
    @ngjunsiang
    ngjunsiang committed May 18, 2024
    Configuration menu
    Copy the full SHA
    738382d View commit details
    Browse the repository at this point in the history

  3. [feat] bitfield factory function, NetId and SpreadSpectrum record cla… 

    …sses

These two classes require the use of bitfields, which until now has not been implemented.
The interface and design of these two classes is not yet final.
Discussion and testing of this interface is recommended before finalization and further work on other bitfield records.
    @ngjunsiang
    ngjunsiang committed May 18, 2024
    Configuration menu
    Copy the full SHA
    c0fb495 View commit details
    Browse the repository at this point in the history

  4. [docs] TransmitterPdu comments cleanup

    @ngjunsiang
    ngjunsiang committed May 18, 2024
    Configuration menu
    Copy the full SHA
    346b8bf View commit details
    Browse the repository at this point in the history

  5. [refactor] Add default values to allow init without initial values 

    This follows the pattern established by the classes in dis7.py
    @ngjunsiang
    ngjunsiang committed May 18, 2024
    Configuration menu
    Copy the full SHA
    1b7f071 View commit details
    Browse the repository at this point in the history

  6. [refactor] Use SpreadSpectrum in ModulationType 

    Initial test for bitfield class
    @ngjunsiang
    ngjunsiang committed May 18, 2024
    Configuration menu
    Copy the full SHA
    bff4aa3 View commit details
    Browse the repository at this point in the history

  7. [fix] bugfixes

    @ngjunsiang
    ngjunsiang committed May 18, 2024
    Configuration menu
    Copy the full SHA
    a86ae5c View commit details
    Browse the repository at this point in the history

  8. Merge branch 'open-dis:master' into feat-bitfield

    @ngjunsiang
    ngjunsiang authored May 18, 2024
    Configuration menu
    Copy the full SHA
    3b5cf7a View commit details
    Browse the repository at this point in the history

  9. [cleanup] minor edits

    @ngjunsiang
    ngjunsiang committed May 18, 2024
    Configuration menu
    Copy the full SHA
    ba89412 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'master' into feat-bitfield

    @ngjunsiang
    ngjunsiang committed May 18, 2024
    Configuration menu
    Copy the full SHA
    8a1ea52 View commit details
    Browse the repository at this point in the history

  11. [fix] Bitfield packs into correct number of bytes 

    The fields fall back on default size for c_uint if not specified, resulting in the bitfield packing
a 16-bit bitfield into 4 bytes instead of 2.
This fix induces the correct packing behaviour.
    @ngjunsiang
    ngjunsiang committed May 18, 2024
    Configuration menu
    Copy the full SHA
    1aaaa87 View commit details
    Browse the repository at this point in the history

  12. [fix] Use SpreadSpectrum to parse and serialize stream

    @ngjunsiang
    ngjunsiang committed May 18, 2024
    Configuration menu
    Copy the full SHA
    9acd3b8 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2024

  1. [fix] SignalPdu correctly parses data samples 

    This was missed in an earlier refactor that converted length/count attributes into properties.
    @ngjunsiang
    ngjunsiang committed May 19, 2024
    Configuration menu
    Copy the full SHA
    d9e211c View commit details
    Browse the repository at this point in the history