Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect contact #1380

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Redirect contact #1380

wants to merge 2 commits into from

Conversation

DRH-TBS
Copy link
Contributor

@DRH-TBS DRH-TBS commented May 23, 2023

No description provided.

updated contact us to all contacts
Added translation for all contacts
@DRH-TBS DRH-TBS requested a review from wardi May 23, 2023 20:41
@wardi
Copy link
Member

wardi commented May 23, 2023

By "with a good commit message" I mean create a commit with a better commit message than "update footer.html" and "update ckanext-canada.po". I know it's a small thing but it makes it much easier when we need to go back through the commit history when rebasing or debugging.

@wardi
Copy link
Member

wardi commented May 23, 2023

Also "redirect" has a specific technical meaning in web applications. How about "Rename contact link to All contacts" instead

Copy link
Member

@wardi wardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By "with a good commit message" I mean create a commit with a better commit message than "update footer.html" and "update ckanext-canada.po". I know it's a small thing but it makes it much easier when we need to go back through the commit history when rebasing or debugging.

Also "redirect" has a specific technical meaning in web applications. How about "Rename contact link to All contacts" instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants