Skip to content

chore: cleanup migration + duplicate #1433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mandelsoft
Copy link
Contributor

@mandelsoft mandelsoft commented Apr 29, 2025

What this PR does / why we need it

  • Cleanup some artifacts from the migration
  • deprecate duplication functions in api/utils

Which issue(s) this PR fixes

@mandelsoft mandelsoft requested a review from a team as a code owner April 29, 2025 18:32
@github-actions github-actions bot added kind/chore chore, maintenance, etc. size/l Large area/documentation Documentation related component/ocm-cli OCM Command Line Interface kind/dependency dependency update, etc. and removed size/l Large labels Apr 29, 2025
Copy link
Contributor

@jakobmoellerdev jakobmoellerdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whats the reason for deprecating the OCM internal utils in favor of mandelsoft? to me this is undesired during a cleanup and duplication removal that is cross-package. We should only upgrade usages that already exist.

@mandelsoft
Copy link
Contributor Author

The functions are duplicates, because during the migration not all occurrences have been adapted.
One instance should be sufficient. An we decided mid of last year to extract general functionality not bound to the ocm functionality.

The alternative is to migrate back this completely to the ocm library. But we should have only one source of truth for those functions.

@frewilhelm
Copy link
Contributor

But we should have only one source of truth for those functions.

In theory, I agree. But using libraries from private contributors or without community support is risky. What happens if the contributor no longer has access to the repositories or makes them private? That can lead to much bigger problems.

@Skarlso
Copy link
Contributor

Skarlso commented Apr 30, 2025

The alternative is to migrate back this completely to the ocm library.

Let's do that because of the above, what Frederic mentioned. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Documentation related component/ocm-cli OCM Command Line Interface kind/chore chore, maintenance, etc. kind/dependency dependency update, etc. size/l Large
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants