Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make container resources configurable #163

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dhaiducek
Copy link
Member

@dhaiducek dhaiducek commented Jun 15, 2024

Currently missing tests, but adds CustomizedVariables for memory limits and requests, forbidding setting values below the defaults, and setting the request equal to the limit if it exceeds it (since that configuration would be refused).

Copy link

openshift-ci bot commented Jun 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhaiducek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Dale Haiducek <[email protected]>
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants