Add --plaintext flag for pushing to http registries such as localhost #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! I was trying out the policy command with a localhost registry for testing, and discovered that I couldn't push to a localhost registry on
http. The insecure flag skips TLS Verification, but usinghttpsas the Scheme in the docker registry was hard-coded. This PR adds a--plaintextflag which allows this to be configurable.I did a quick comparison with other tools to come up with the name. The lingo of
--plaintextmatches ArgoCD's behaviour. Incranethey just use--insecureto mean "connect to the registry over http".Comparison with other tools
ArgoCD
--insecure= no TLS verify--plaintext= Use HTTP client/serverCrane's
--insecureoption allows for HTTP scheme on registrydoc
how it's used