Skip to content
This repository has been archived by the owner on Apr 1, 2020. It is now read-only.

add slash back for cmdline search #2374

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Piping
Copy link

@Piping Piping commented Jun 29, 2018

Hi,

vim has // syntax for last search. However, the Oni command line search will not display the first character like / or ? .

This pull request is to restore the behavior.

@akinsho
Copy link
Member

akinsho commented Jun 29, 2018

@Piping there is an option which possibly isn't sufficiently well documented with the commandline externalisation to actually disable the use of the icons if you would prefer to see the original vim characters.

The intention was that users can opt in to gui icons if they like otherwise they can stick with the vim characters the option I believe is "commandline.icons": false

@Piping
Copy link
Author

Piping commented Jun 29, 2018

@Akin909 I like the icon! And I want to keep it. / or ? is not just a character that active the search, but for vim users, it can also mean last searched text. E.g. // or ?? , similar to :, it means command line text that can be combined with @:. (@/, @?, d//, etc..)

@akinsho
Copy link
Member

akinsho commented Jun 29, 2018

@Piping the though process behind the icons was that it would be the one or the other aka if new users happened upon the command line they would get a gui icon they could guess at functionality for from the icon and power vim users would just turn it off I think a hybrid of the two sort of defeats the intention, the icons are supposed to be a gui stand-in for / and ?

@Piping
Copy link
Author

Piping commented Jun 30, 2018

@Akin909 gui icon adds more info for users to understand whats going on. But icon definitely does not replace /. I was very surprised when I pressed / and did not see it on the screen. I have to guess what's happened.

consider the case, when the user coming from stack overflow, and learn how to use search in vim.
and then they open oni and press /, they probably used to the cmdline indicating / is pressed but they see nothing. Frankly, the icon does not convey which type of search here, like search for text? files? or something different? It is better to show what user has typed, rather than hide it intentionally.

And the search pattern always looks like /abc or // etc.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants