[Compiler] Test optional arguments

[RZhang05]

Closes #3996

Description

Renames Transfer instruction to TransferAndConvert and introduces a new Transfer instruction which only calls Transfer on the value. This is necessary for optional arguments in method invocation where the parameter type is unknown.

---

• Targeted PR against master branch
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work
• Code follows the standards mentioned here
• Updated relevant documentation
• Re-reviewed Files changed in the Github PR explorer
• Added appropriate labels

[github-actions]

Cadence Benchstat comparison

This branch with compared with the base branch onflow:feature/compiler commit 39e93d7
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

[SupunS]

Nice!
So I guess because we already provide the argument-count in the invoke instructions, we don't have to do anything specific?

[turbolent]

Nice! Great to see this already works for function invocations.

We also have built-in methods that have optional/variable arguments, like e.g. the Account.Contract.add method (

cadence/sema/account.go

Line 64 in 163d49a

Account_ContractsTypeAddFunctionType.Arity = &Arity{Min: 2}

). Could you please add some tests for method invocations as well?

[turbolent]

Great work! 👏