Skip to content

[Compiler] Compile second value assignment #3987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 30, 2025

Conversation

SupunS
Copy link
Member

@SupunS SupunS commented May 29, 2025

Work towards #3976

Description

While at it, also added support for nested resource moves, which is generally used along with the second value assignments.


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@SupunS SupunS self-assigned this May 29, 2025
@SupunS SupunS added the Feature label May 29, 2025
Copy link

Cadence Benchstat comparison

This branch with compared with the base branch onflow:feature/compiler commit cd6f627
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

@SupunS SupunS force-pushed the supun/second-value-assignment branch from 6d145f0 to 41c0c3d Compare May 29, 2025 20:37
@SupunS SupunS marked this pull request as ready for review May 29, 2025 20:59
@SupunS SupunS requested a review from turbolent as a code owner May 29, 2025 20:59
@SupunS SupunS requested a review from RZhang05 May 29, 2025 20:59
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thanks for also adding the new instructions

@SupunS SupunS merged commit c3dbf57 into feature/compiler May 30, 2025
8 of 9 checks passed
@SupunS SupunS deleted the supun/second-value-assignment branch May 30, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants