[Compiler] Fix condition compiling #3877
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #3769
Description
There were three issues:
emit Event()
), then the global lookup fail for the concrete type when compiling this inherited condition. (✅ Fixed).emit Event()
→emit Contract.Event()
A.foo()
inside the condition and interface has an import toA
. But the concrete type that inherits the same condition does not importA
. ThenA.foo
cannot be found to the compiler.) (❌ Not fixed yet).master
branchFiles changed
in the Github PR explorer