Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Compiler] Implement scoping #3789

Open
wants to merge 1 commit into
base: bastian/break-switch
Choose a base branch
from
Open

[Compiler] Implement scoping #3789

wants to merge 1 commit into from

Conversation

turbolent
Copy link
Member

@turbolent turbolent commented Feb 21, 2025 •
edited
Loading

Work towards #3742
Depends on #3787

Description

Implement scoping for blocks and if-let statements. For loops are not implemented yet, but will also need to be scoped.

Fix scoping of variable declaration (value must be evaluated before declaring variable).

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent requested a review from jsproz February 21, 2025 23:30
@turbolent turbolent self-assigned this Feb 21, 2025
@turbolent turbolent requested a review from SupunS as a code owner February 21, 2025 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsproz jsproz Awaiting requested review from jsproz

@SupunS SupunS Awaiting requested review from SupunS SupunS is a code owner

Assignees

@turbolent turbolent

Labels
Bugfix Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@turbolent