New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: reserved system name checks when creating templates #746
Open
Vafilor
wants to merge
104
commits into
onepanelio:master
Choose a base branch
from
Vafilor:fix/onepanelio.core.256-reserved.names
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix: reserved system name checks when creating templates #746
Vafilor
wants to merge
104
commits into
onepanelio:master
from
Vafilor:fix/onepanelio.core.256-reserved.names
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ient logic for determining resource counts
… sure they don't allow sys- prefixed names. Also updated workspace creation so that the workflow templates created by workspace templates have a sys- prefix.
chore: Add issue templates
fix: Add migration for changes in TFOD and CVAT template
Code looks good, need to go through test cases. |
Point of concern.
|
@aleksandrmelnikov Ah, good catch. I'll add a migration to update the old names. |
…rgo workflow templates.
…ifies the code a little.
fix: Move env vars to workspace creation
…les into their own subdirectory for easier separation of files.
feat: upgrade grpc
chore: Update demo note
… sure they don't allow sys- prefixed names. Also updated workspace creation so that the workflow templates created by workspace templates have a sys- prefix.
…rgo workflow templates.
…ifies the code a little.
…afilor/core into fix/onepanelio.core.256-reserved.names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Updated workspace templates' associated workflow templates to have a sys- prefix to indicate it is a system resource.
Also added checks to workflow/workspace template creation so they don't allow sys- prefixes.
Which issue(s) this PR fixes:
Fixes #256
Special notes for your reviewer:
To test:
Try creating a workflow template and workspace template with a sys- prefixed name. You should get an error.
Try creating a workspace template and check in the database that the newly created workflow template has a sys- prefixed name.
Checklist
Please check if applies
Required