Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FPGA: Add new sample SVD #2320

Open
wants to merge 42 commits into
base: development
Choose a base branch
from
Open

Conversation

KevinUTAT
Copy link
Contributor

@KevinUTAT KevinUTAT commented May 3, 2024

Description

Adding a new FPGA reference design Singular Value Decomposition.

Testing

Running reg-tests, will update test links once finished.

Checklist

Administrative

  • Review sample design with the appropriate Domain Expert:
  • If you have any new dependencies/binaries, inform the oneAPI Code Samples Project Manager

Code Development

Security and Legal

  • OSPDT Approval (see Project Manager for assistance)
  • Compile using the following compiler flags and fix any warnings, the falgs are: "/Wall -Wformat-security -Werror=format-security"
  • Bandit Scans (Python only)
  • Virus scan

Review

  • Review DPC++ code with Paul Peterseon. (GitHub User: pmpeter1)
  • Review readme with Tom Lenth(@tomlenth) and/or Project Manager
  • Tested using Dev Cloud when applicable

@jimmytwei
Copy link
Contributor

Adding @pmpeter1 and @tomlenth per request by @KevinUTAT

@KevinUTAT KevinUTAT requested a review from pmpeter1 May 15, 2024 14:36
Copy link
Contributor

@tomlenth tomlenth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty solid. thx!

@KevinUTAT KevinUTAT requested a review from pmpeter1 May 16, 2024 21:11
Copy link
Contributor

@yuguen-intel yuguen-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you get the chance to compute estimated performance to compare with what you obtained in HW?

Example Output when running on the **Terasic DE10-Agilex Development Board**.

```
Running on device: de10_agilex : Agilex Reference Platform (aclde10_agilex0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run this sample on N6001 to update the readme from DE10 to N6001 as we moved to this board.


*/
template <typename T>
class GoldenPCA {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PCA? I guess you meant SVD? Or maybe you didn't mean to add this file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copy the golden PCA to obtain the eigen values for reference, so it technically is PCA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants