Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(/recent): add recent reviews view #130

Merged
merged 10 commits into from
Aug 9, 2022
Merged

feat(/recent): add recent reviews view #130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
1182e21
fix(db): correct logic in `getReviewsRecent50()`
Aug 9, 2022
b4fc54c
fix: change color scheme to more intuitive scale
Aug 9, 2022
3c770d2
feat(recents): init new components
Aug 9, 2022
02e5af6
feat(NavBar): add new view to nav bar
Aug 9, 2022
0dcf3b7
refactor: extract entity `CourseDataStatic`
Aug 9, 2022
3de6008
refactor(ReviewCard): add course info to card
Aug 9, 2022
52058e4
feat: add return button in `/recents`
Aug 9, 2022
b1f53e4
fix(review): lots of styling updates
tran-christian Aug 9, 2022
894534a
fix(styling): fix loading icon and long course titles
tran-christian Aug 9, 2022
26c1143
chore: run linter
Aug 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions firebase/dbOperations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import {
TPayloadReviews,
TPayloadSemesters,
TPayloadSpecializations,
} from '../globals/types'
} from '@globals/types'
import { parseReviewId } from './utilityFunctions'
import {
addOrUpdateReview,
Expand Down Expand Up @@ -290,8 +290,9 @@ export const getReviews = async (
export const getReviewsRecent50 = async () => {
try {
const snapshot = await getDoc(doc(db, baseDocumentReviewsRecent50))
const recentReviews50 = snapshot.data()
return recentReviews50 ?? null
const data = snapshot.data()
const recentReviews50: Review[] = data ? data?.data : []
return recentReviews50
} catch (e: any) {
console.log(e)
throw new Error(e)
Expand Down
Loading