Upgrade to rabbitmq-c-fb6fca832fd2 #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removing all the features that were added into Net::RabbitMQ isn't really an acceptable step. If you want to update the rabbitmq-c stuff, pull the new sources and merge in the additions we've make over time in the Net::RabbitMQ source base. Those changes are critical to make this module useful for AMQP interaction within Perl. |
|
I may be interested in taking this on. @postwait, what is left to do? Would you prefer a start over? If so, what version of librabbitmq-c is already present? |
|
I've done a bit of work to actually split the two libraries so that we could get some bug fixes from more recent versions of the c library without having to rebuild Net::RabbitMQ each time. See https://github.com/emarcotte/Net--RabbitMQ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haved upgraded Net::RabbitMQ to rabbitmq-c-fb6fca832fd2 and got rid of a segmentation fault in #13. Unfortunately I have not implemented the features added only to Net::RabbitMQ. So you may merge it so that the new features remain.