-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pyemma] bump version 2.3.1 #696
Conversation
The Appveyor queue for Roberts account seems stuck. I've reported this in support forums. I hope this will be fixed soon. |
Looks like we're running into another
|
mdtraj/geometry/src/_geometry.cpp(5047) : error C3861: 'roundf': identifier not found |
|
|
The function is only defined for _MSC_VER < 1900, but for this compiler it should be included (vc9). |
mdtraj dropped support for python2.7 on windows like 8 months ago. @franknoe: How should we deal with this? I strongly suggest to require mdtraj>=1.8, because of the NaN geometry bug fixed in this version. We can unpin it for windows users and print a big fat warning, suggesting to upgrade to python3. |
What about patching out the tng extension for window < py35 |
We should discuss in Omnia how to generally handle this. We cannot
simply stop Python 2 support without notice, so we have to find a
strategy to deal with this in a way that's not destructive for users.
Am 07/02/17 um 01:10 schrieb Martin K. Scherer:
…
mdtraj dropped support for python2.7 on windows like 8 months ago.
@franknoe <https://github.com/franknoe>: How should we deal with this?
I strongly suggest to require mdtraj>=1.8, because of the NaN geometry
bug fixed in this version. We can unpin it for windows users and print
a big fat warning, suggesting to upgrade to python3.
***@***.***
<mdtraj/mdtraj@ed28733>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#696 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGMeQo_BKssMykMNSTec_CpFzHxqJgBPks5rZ7Z9gaJpZM4L4ROi>.
--
----------------------------------------------
Prof. Dr. Frank Noe
Head of Computational Molecular Biology group
Freie Universitaet Berlin
Phone: (+49) (0)30 838 75354
Web: research.franknoe.de
Mail: Arnimallee 6, 14195 Berlin, Germany
----------------------------------------------
|
On 07.02.2017 01:20, Matthew Harrigan wrote:
What about patching out the tng extension for window < py35
I've already fixed tng for this configuration. Now the compiler does not
find roundf.
|
Agreed that we should discuss this. We tried to get a discussion of this going in July 2016 in this thread, but there was never enough momentum to actually commit to deprecating python 2.x. MDtraj decided unilaterally to deprecate python 2.x, so now we're stuck with this issue. |
Is there a possibility of getting the mdtraj developers to do a bugfix release for the last mdtraj release to support python 2.7? That seems like a reasonable burden to carry given the decision to drop python 2.x support. |
I think they dropped the support because of all the hassle of the lacking/partial C99 support of the old M$ compiler. However with a few patches/workarounds this should be easy to support. I don't think mdtraj makes use of new py3k exclusive language features, do they? |
inlining the definition works great. So now only parmed and solvationkit fails for py27, IMHO this mergable now. |
Woohoo! Thanks! |
@jchodera it's py27 on windows |
On 07.02.2017 09:57, Frank Noe wrote:
We should discuss in Omnia how to generally handle this. We cannot
simply stop Python 2 support without notice, so we have to find a
strategy to deal with this in a way that's not destructive for users.
I think we've agreed at the Omnia meeting to continue the support for
2.7 to have a smooth transition to Python3. We have to encourage users
(omni-present) to upgrade soon.
Since I've fixed the build problems for this version/platform in mdtraj,
I could imagine, that @mpharrigan could be willing to re-include 2.7 in
the testing matrix. The packages for the recent release are already online.
|
No description provided.