Merged
Conversation
thakurajayL
force-pushed
the
thakurajayL-patch
branch
5 times, most recently
from
a46343e to
2ea5f1a
Compare
gab-arrobo
requested changes
Jan 13, 2025
Contributor
gab-arrobo
left a comment
gab-arrobo
left a comment
There was a problem hiding this comment.
Overall, it looks good. Adding some comments
Contributor
|
@thakurajayL, you need to sign-off your commit(s) to successfully pass the |
thakurajayL
force-pushed
the
thakurajayL-patch
branch
2 times, most recently
from
37ad06e to
fb9c009
Compare
gab-arrobo
reviewed
Jan 15, 2025
Contributor
|
@thakurajayL, you need to sign-off you last commit (the DCO filed for it) |
Signed-off-by: Ajay Lotan Thakur <thakur.ajay@gmail.com>
Signed-off-by: Ajay Lotan Thakur <thakur.ajay@gmail.com>
Signed-off-by: Ajay Lotan Thakur <thakur.ajay@gmail.com>
Co-authored-by: gab-arrobo <gabriel.arrobo@intel.com> Signed-off-by: Ajay Lotan Thakur <thakur.ajay@gmail.com>
Co-authored-by: gab-arrobo <gabriel.arrobo@intel.com> Signed-off-by: Ajay Lotan Thakur <thakur.ajay@gmail.com>
Co-authored-by: gab-arrobo <gabriel.arrobo@intel.com> Signed-off-by: Ajay Lotan Thakur <thakur.ajay@gmail.com>
Co-authored-by: gab-arrobo <gabriel.arrobo@intel.com> Signed-off-by: Ajay Lotan Thakur <thakur.ajay@gmail.com>
Co-authored-by: gab-arrobo <gabriel.arrobo@intel.com> Signed-off-by: Ajay Lotan Thakur <thakur.ajay@gmail.com>
Signed-off-by: Ajay Lotan Thakur <thakur.ajay@gmail.com>
* add MongoDB functions to handle transactions Signed-off-by: Patricia Reinoso <patricia.reinoso@canonical.com> * rename to supports transactions Signed-off-by: Patricia Reinoso <patricia.reinoso@canonical.com> --------- Signed-off-by: Patricia Reinoso <patricia.reinoso@canonical.com> Signed-off-by: Ajay Lotan Thakur <thakur.ajay@gmail.com>
Co-authored-by: gab-arrobo <gabriel.arrobo@intel.com> Signed-off-by: Ajay Lotan Thakur <thakur.ajay@gmail.com>
thakurajayL
force-pushed
the
thakurajayL-patch
branch
from
1a31c65 to
38222ff
Compare
gab-arrobo
approved these changes
Jan 16, 2025
Contributor
gab-arrobo
left a comment
gab-arrobo
left a comment
There was a problem hiding this comment.
+1 (tested changes with OnRamp using the replace directive in the amf pod/image)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Logging updates and code review.