Enable linters (#118)

* Enable `gofumpt` linter

* Enable `gci` linter

* Enable `whitespace` linter

* Enable `gosimple` linter

* Enable `ineffassign` linter

* Enable `goconst` linter

.golangci.yml

@@ -1,7 +1,7 @@
 # Copyright 2019 free5GC.org
 #
 # SPDX-License-Identifier: Apache-2.0
-# 
+#
 
 # This file contains all available configuration options
 # with their default values.
@@ -218,23 +218,22 @@ linters:
     - errcheck
     - staticcheck
     - unused
-    # - gosimple
-    # - ineffassign
+    - gosimple
+    - ineffassign
     - typecheck
     # Additional
     # - lll
     - godox
     #- gomnd
-    #- goconst
+    - goconst
     # - gocognit
-    # - maligned
     # - nestif
     # - gomodguard
     # - nakedret
-    # - gci
+    - gci
     - misspell
-    # - gofumpt
-    # - whitespace
+    - gofumpt
+    - whitespace
     - unconvert
     - predeclared
     - noctx
@@ -243,7 +242,7 @@ linters:
     - asciicheck
       #- stylecheck
       # - unparam
-      #- wsl
+      # - wsl
 
   #disable-all: false
   fast: true

eventexposure/routers.go

@@ -20,8 +20,8 @@ import (
 
 	"github.com/gin-gonic/gin"
 
-	logger_util "github.com/omec-project/util/logger"
 	"github.com/omec-project/udm/logger"
+	logger_util "github.com/omec-project/util/logger"
 )
 
 // Route is the information for every URI.

parameterprovision/routers.go

@@ -20,8 +20,8 @@ import (
 
 	"github.com/gin-gonic/gin"
 
-	logger_util "github.com/omec-project/util/logger"
 	"github.com/omec-project/udm/logger"
+	logger_util "github.com/omec-project/util/logger"
 )
 
 // Route is the information for every URI.

producer/event_exposure.go

@@ -16,6 +16,8 @@ import (
 	"github.com/omec-project/util/httpwrapper"
 )
 
+const anyUE = "anyUE"
+
 func HandleCreateEeSubscription(request *httpwrapper.Request) *httpwrapper.Response {
 	logger.EeLog.Infoln("Handle Create EE Subscription")
 
@@ -96,7 +98,7 @@ func CreateEeSubscriptionProcedure(ueIdentity string,
 		})
 		return createdEeSubscription, nil
 	// represents any UEs
-	case ueIdentity == "anyUE":
+	case ueIdentity == anyUE:
 		id, err := udmSelf.EeSubscriptionIDGenerator.Allocate()
 		if err != nil {
 			problemDetails := &models.ProblemDetails{
@@ -157,7 +159,7 @@ func DeleteEeSubscriptionProcedure(ueIdentity string, subscriptionID string) {
 			}
 			return true
 		})
-	case ueIdentity == "anyUE":
+	case ueIdentity == anyUE:
 		udmSelf.UdmUePool.Range(func(key, value interface{}) bool {
 			ue := value.(*udm_context.UdmUeContext)
 			delete(ue.EeSubscriptions, subscriptionID)
@@ -232,7 +234,7 @@ func UpdateEeSubscriptionProcedure(ueIdentity string, subscriptionID string,
 			return true
 		})
 		return nil
-	case ueIdentity == "anyUE":
+	case ueIdentity == anyUE:
 		udmSelf.UdmUePool.Range(func(key, value interface{}) bool {
 			ue := value.(*udm_context.UdmUeContext)
 			if _, ok := ue.EeSubscriptions[subscriptionID]; ok {

service/init.go

@@ -323,7 +323,7 @@ func (udm *UDM) updateConfig(commChannel chan *protos.NetworkSliceResponse) bool
 							break
 						}
 					}
-					if found == false {
+					if !found {
 						self.PlmnList = append(self.PlmnList, temp)
 						logger.GrpcLog.Infoln("Plmn added in the context", self.PlmnList)
 					}
@@ -332,7 +332,7 @@ func (udm *UDM) updateConfig(commChannel chan *protos.NetworkSliceResponse) bool
 				}
 			}
 		}
-		if minConfig == false {
+		if !minConfig {
 			// first slice Created
 			if len(self.PlmnList) > 0 {
 				minConfig = true
@@ -382,7 +382,7 @@ func (udm *UDM) BuildAndSendRegisterNFInstance() (models.NfProfile, error) {
 		return profile, err
 	}
 	initLog.Infof("UDM Profile Registering to NRF: %v", profile)
-	//Indefinite attempt to register until success
+	// Indefinite attempt to register until success
 	profile, _, self.NfId, err = consumer.SendRegisterNFInstance(self.NrfUri, self.NfId, profile)
 	return profile, err
 }

subscriberdatamanagement/routers.go

@@ -20,8 +20,8 @@ import (
 
 	"github.com/gin-gonic/gin"
 
-	logger_util "github.com/omec-project/util/logger"
 	"github.com/omec-project/udm/logger"
+	logger_util "github.com/omec-project/util/logger"
 )
 
 // Route is the information for every URI.

ueauthentication/routers.go

@@ -21,8 +21,8 @@ import (
 	"github.com/gin-gonic/gin"
 	"github.com/sirupsen/logrus"
 
-	logger_util "github.com/omec-project/util/logger"
 	"github.com/omec-project/udm/logger"
+	logger_util "github.com/omec-project/util/logger"
 )
 
 var HttpLog *logrus.Entry

uecontextmanagement/routers.go

@@ -20,8 +20,8 @@ import (
 
 	"github.com/gin-gonic/gin"
 
-	logger_util "github.com/omec-project/util/logger"
 	"github.com/omec-project/udm/logger"
+	logger_util "github.com/omec-project/util/logger"
 )
 
 // Route is the information for every URI.