Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing images, external and internal links #5

Merged
merged 3 commits into from
Oct 10, 2022
Merged

Conversation

pwalczysko
Copy link
Member

Fixing the links for the failing www build

cc @sbesson

2022/2022-03-22.md Outdated Show resolved Hide resolved
Co-authored-by: Josh Moore <[email protected]>
@@ -70,7 +70,6 @@ Start: 2:00 pm
> [<u>https://trello.com/c/nSPx2UJX/235-light-microscopy-australia-09-03-2019</u>](https://trello.com/c/nSPx2UJX/235-light-microscopy-australia-09-03-2019)

- Fun in Singapore:
> <img src="../images/2019-03-12-image1.png" style="width:2.95313in;height:1.65849in" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These images are present, but I'm not sure why they aren't being found:

commit 9806d5586726db3bf29d4496e83c4bb367cecf6c
Author: jmoore <[email protected]>
Date:   Tue Sep 29 21:40:55 2020 +0200

    More image fixes

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on https://github.com/ome/www.openmicroscopy.org/actions/runs/3219662885/jobs/5265329745, the issue with this image is the absence of an alt attribute rather than the fact the source is missing.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, @sbesson is right, @joshmoore I am removing them because I do not have an easy solution about adding an alt attribute. It seems that this needs javascript abilities, or somesuch ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should be as easy as adding alt="some description" to the <img .../> block.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @joshmoore fixed in e08d85a

@pwalczysko
Copy link
Member Author

Created #6

@pwalczysko pwalczysko requested a review from joshmoore October 10, 2022 15:33
@pwalczysko pwalczysko merged commit 2a9044d into master Oct 10, 2022
@pwalczysko pwalczysko deleted the fix-failures branch October 10, 2022 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants