UpgradeChecker: more thorough check of upgrade check result and HTTP response code #4260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…response code This tries to handle the cases where the result of the upgrade check is non-empty string indicating that something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tries to handle the cases where the result of the upgrade check is non-empty string indicating that something went wrong.
The original issue that prompted this change was a
Too many hits ...response from the registry, which was incorrectly interpreted as a new version being available.Effectively untested, thus the draft status. We likely need to coordinate some time to test this together with the current state of the registry, to make sure both pieces are actually working together as intended.
cc @jburel @chris-allan