OIR: parse time step from TIMELAPSE axis when possible #4259
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://forum.image.sc/t/bio-formats-reads-wrong-time-interval-from-oir-time-lapse-images/105684/
Without this change,
showinf -nopix -omexml
on the provided file (incurated/olympus-oir/imagesc-105684/
) should showPlane.DeltaT
values spaced ~2.17 seconds apart. With this change,Plane.DeltaT
values should be spaced 30 seconds apart.The time step is now being parsed the same way that the Z step is parsed, so I think this makes sense. I would expect some test failures overnight in the
DeltaT
test for existing .oir data; I can update configs as needed later in the week, or we can exclude temporarily.