Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DONOTMERGE] generate_email uses production domains. #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

omaciel
Copy link
Owner

@omaciel omaciel commented Jul 1, 2014

This fixes issue #26.

@omaciel
Copy link
Owner Author

omaciel commented Jul 1, 2014

@Ichimonji10 is this what you wanted?

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 57c3ab8 on issue-26 into ee5df15 on master.

@Ichimonji10
Copy link
Contributor

Naah, this isn't what I'm looking for. The changes in this commit are a mis-reading of the RFC — good try, though! I'll give a more thorough explanation tomorrow.

@Ichimonji10
Copy link
Contributor

Ok, so RFC 2606 states that the following domains are reserved:

  • test
  • example
  • invalid
  • localhost

Notice that those are all top level domains. That's the really important part: they're top level. Thus, these domains all fall under the scope of RFC 2606:

  • omaciel.wordpress.example
  • bad-ssl-certs.super-unsafe-site.invalid
  • development-webserver.localhost
  • fourth.third.second.test

However, the following do not fall under the scope of RFC 2606:

  • example.biz
  • invalid.com
  • localhost.net
  • test.com

This PR places example, invalid, localhost and test in the SUBDOMAINS list, which will produce domains of the second type. Those domains should go into TLDS, so as to produce domains of the first type.

All that said, com, net and org can be used as top-level domains. However, they can only be used as top-level domains if example is used as a second-level domain. Thus, the following are all valid:

  • example.com
  • third.example.com
  • fourth.third.example.com
  • fourth.third.example.net

… and so on.

@omaciel omaciel changed the title generate_email uses production domains. [DONOTMERGE] generate_email uses production domains. Sep 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants