Skip to content

best_prefix produces invalid results #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
olbrich merged 3 commits into from
Sep 1, 2024
Merged

best_prefix produces invalid results #347

olbrich merged 3 commits into from
Sep 1, 2024

Conversation

@olbrich
Copy link
Owner

@olbrich olbrich commented Mar 16, 2024

Fixes #170

Some tweaks to the best_prefix method.

  1. Doesn't do anything to units with a 'kg' in the name.
  2. Uses 'centi' prefix for scalars between 0.1 and 0.01

@olbrich olbrich self-assigned this Mar 16, 2024
@olbrich olbrich added the Patch backwards-compatible bug fixes label Mar 16, 2024
@olbrich olbrich merged commit 08c7414 into master Sep 1, 2024
@olbrich olbrich deleted the issue170-best_prefix-produces-invalid-results branch September 1, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@olbrich olbrich

Labels

Patch backwards-compatible bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

best_prefix produces invalid results

2 participants

@olbrich